Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calling default lambda only once per delegate #69

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tobiberger
Copy link

When using a missing argument multiple times, the lambda that provides a default value was called at every use of the delegate. In some cases, like asking the user to input the value on command line, this behaviour can be undesirable.

@codecov-io
Copy link

Codecov Report

Merging #69 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #69      +/-   ##
============================================
+ Coverage      84.9%   84.94%   +0.03%     
  Complexity      138      138              
============================================
  Files            11       11              
  Lines           424      425       +1     
  Branches         84       84              
============================================
+ Hits            360      361       +1     
  Misses           27       27              
  Partials         37       37
Impacted Files Coverage Δ Complexity Δ
...c/main/kotlin/com/xenomachina/argparser/Default.kt 84.21% <100%> (+0.87%) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 263784f...1fb46a4. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants