Avoid explicit class name in throw_exception #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
added a commit
to apache/spark
that referenced
this pull request
Feb 1, 2023
### What changes were proposed in this pull request? This PR aims to upgrade `snappy-java` to 1.1.9.1. ### Why are the changes needed? This version has the following bug fixes. - Use original compressed and uncompressed buffer's position (xerial/snappy-java#293) - Fixed running snappy-java as OSGi bundle on Apple Silicon (M1 Pro) (xerial/snappy-java#303) - Avoid explicit class name in throw_exception (xerial/snappy-java#291) Here is the full release note. - https://github.com/xerial/snappy-java/releases/tag/v1.1.9.0 - https://github.com/xerial/snappy-java/releases/tag/v1.1.9.1 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. Closes #39811 from dongjoon-hyun/SPARK-42242. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun
added a commit
to apache/spark
that referenced
this pull request
Feb 1, 2023
### What changes were proposed in this pull request? This PR aims to upgrade `snappy-java` to 1.1.9.1. ### Why are the changes needed? This version has the following bug fixes. - Use original compressed and uncompressed buffer's position (xerial/snappy-java#293) - Fixed running snappy-java as OSGi bundle on Apple Silicon (M1 Pro) (xerial/snappy-java#303) - Avoid explicit class name in throw_exception (xerial/snappy-java#291) Here is the full release note. - https://github.com/xerial/snappy-java/releases/tag/v1.1.9.0 - https://github.com/xerial/snappy-java/releases/tag/v1.1.9.1 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. Closes #39811 from dongjoon-hyun/SPARK-42242. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 65a1c16) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
### What changes were proposed in this pull request? This PR aims to upgrade `snappy-java` to 1.1.9.1. ### Why are the changes needed? This version has the following bug fixes. - Use original compressed and uncompressed buffer's position (xerial/snappy-java#293) - Fixed running snappy-java as OSGi bundle on Apple Silicon (M1 Pro) (xerial/snappy-java#303) - Avoid explicit class name in throw_exception (xerial/snappy-java#291) Here is the full release note. - https://github.com/xerial/snappy-java/releases/tag/v1.1.9.0 - https://github.com/xerial/snappy-java/releases/tag/v1.1.9.1 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. Closes apache#39811 from dongjoon-hyun/SPARK-42242. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 65a1c16) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically I think we can avoid using explicit classname in the native code. I also plan to change the native methods binding using
RegisterNativesin next step, if it can make snappy-java work for dependency relocation situation.