prefer use of java.util.zip.CRC32C #269
Merged
+1,426
−1,379
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
java 9 introduced a jre implementation of crc32: https://docs.oracle.com/javase/9/docs/api/java/util/zip/CRC32C.html
The hotspot jvm also includes intrinsics for native optimizations. According to this issue[1], as long as you are on a recent version (last 2 years), the non-intrinsified implementation is ~2x faster than the hadoop pure java implementation (which is what PureJavaCrc32C is based on). The intrinsified implementation is another 2-3x faster than that.
[1] - https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8191328