Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update packages in generated projects #355

Merged
merged 4 commits into from Apr 12, 2018

Conversation

luboskmetko
Copy link
Member

Fixes #353

Also added eslint and stylelint as dependencies. Didn't update Gulp and Webpack to v4 as those produce some errors which require a more detailed look.

@jakub300
Copy link
Collaborator

Hey, I looked briefly on packages with breaking updates (based on version numbers) and only thing I wonder is whether olegskl/gulp-stylelint#85 is still an issue?

@luboskmetko
Copy link
Member Author

@jakub300 good call. Unfortunately, it's still an issue even in the latest 7.0.0 version, did a few tests with my test case here https://github.com/luboskmetko/test-gulp-stylelint

We could keep 3.9.0 version but that one uses stylelint v7.13.0 and there have been a lot of changes and fixes in stylelint since then (now at v9.1.3). Not sure if that causes any troubles in real projects, but we probably should think how to address this without relying on a fix in gulp-stylelint. Should we use some other plugin, eg the webpack one?

cc @arturkot

@jakub300
Copy link
Collaborator

Could you try to go back to not working version and ignore vendor by passing it to gulp.src, something like:

gulp.src([path.join(src.base, src.styles), `!${path.join(src.base, 'styles/vendor/**/*')}`])

If it works I think it would be enough for us.

@luboskmetko
Copy link
Member Author

Actually, it's not only about vendor folder, users should be able to easily set specific folders to be ignored, for example whole src like described here https://www.getchisel.co/docs/development/code-quality/

@jakub300
Copy link
Collaborator

jakub300 commented Mar 29, 2018

It looks like you downgraded gulp-stylelint back to old version but stylelint v9 is still in dependencies

@luboskmetko
Copy link
Member Author

@jakub300 I've removed stylelint v9 from dependencies

@luboskmetko luboskmetko merged commit d2e9154 into xfiveco:master Apr 12, 2018
@luboskmetko luboskmetko deleted the project-packages-update branch April 12, 2018 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants