Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore type definitions #24

Merged
merged 1 commit into from Jul 24, 2023
Merged

Conversation

cjboy76
Copy link
Contributor

@cjboy76 cjboy76 commented Jul 17, 2023

This PR is about typescript error Could not find a declaration file.


After looking into this, I found some related issues:
vuex#2213
vuex#2223

It seems like typescript would ignore types definitions in package.json depends on nodeResolution.
So I try to manually modify node_ modules like vuex#2223 and it works fine.

Let me know any updates, thank you.

env:

"vue": "^3.3.4",
"vue-sonner": "^0.3.3",
"vite": "^4.3.9",
"typescript": "~5.0.4",
"vue-tsc": "^1.6.5"

@vercel
Copy link

vercel bot commented Jul 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vue-sonner ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2023 10:41am

Copy link
Owner

@xiaoluoboding xiaoluoboding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiaoluoboding xiaoluoboding merged commit 03a9301 into xiaoluoboding:main Jul 24, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants