CMake support, modernized rnnoise example with libsoundfile and CI setup based on Github Actions #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Implemented draft CMake-based buildsystem * Initial read audio-write audio draft with libraris setup * Added lazy filestream writer for dumping VAD value * Adjusted errorcode to the correct one * Adjusted CMakeLists.txt * Adjusted to use exception instead of spdlog error reporting for LazyFileWriter
* Create cmake-multi-platform.yml * Added conan package manager installation * Adjusted line 50 for setup-python action step * Added fixup for libm linking for rnnoise * Attempted to fix the build * One extra attempt * One extra * One extra * Attempted to fixup Windows build * Attempted to fixup windows build * Attempted to fixup build * Attempted to remove build matrix configuration * Adjusted build matrix * Adjusted * Extra * Attempted to fix windows build * Again... * Attempted to fixup fmt build issue * Extra fix for fmt * Adjusted yaml config * Adjusted conan instllation dir * Attempted to fixup * Revert "Attempted to fixup" This reverts commit 19c28b7. * attempted to fixup * One more * Adjusted CI pipeline * Adjusted CI setu * Adjusted a bit * Attempt * Attempt * Attempt * Again... * Again... * Removed listing directories * Runner cleanup
ValentiWorkLearning
changed the title
|
[Valentyn Korniienko]
I've decided to add CMake support for rnnoise and introduce CI/CD
build setup for the project, since it seems to be convenient way of
PRs checking for Linux/Windows builds.
Which build systems did you consider and why did you pick cmake?
I have nothing against the current build system nor cmake, just curiuos
why you believe a change is required and why you ended up with your
selection.
…--
Happy hacking
Petter Reinholdtsen
|
|
@petterreinholdtsen the reason is simple-just because CMake is cross-platform and well supported by IDEs like VSCode/Visual Studio/XCode. I was thinking about bazel, but it doesn't have native support by IDEs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for this great work over this library. I've decided to add CMake support for rnnoise and introduce CI/CD build setup for the project, since it seems to be convenient way of PRs checking for Linux/Windows builds. Also, this PR introduces slightly modernised version of rnnoise example using libsoundfile with the capability of reading WAVE files instead