Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

warn: check if the user is currently blocked #169

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

warn: check if the user is currently blocked #169

wants to merge 2 commits into from

Conversation

hamishzx
Copy link
Collaborator

@hamishzx hamishzx commented Nov 1, 2020

Part of #50

@hamishzx hamishzx marked this pull request as draft November 1, 2020 04:19
@hamishzx hamishzx marked this pull request as ready for review November 1, 2020 05:24
@Xi-Plus
Copy link
Member

Xi-Plus commented Nov 1, 2020

  1. 確實這樣修改能夠處理 在警告/封禁時檢查另一狀態是否改變 #50 中提到的情況，但對於已知封鎖狀況且仍要警告的使用者，會收到不必要的提醒
  2. fetchBlockInfo 可以重用 block 模組的，不必寫新的
  3. 在 Twinkle.warn.callback.evaluate 裡面檢查封鎖狀態就不會導致重複的程式碼

@Xi-Plus Xi-Plus added this to Reviewing in Deployment via automation Nov 17, 2020
@Xi-Plus Xi-Plus moved this from Reviewing to Deployed in Deployment Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Enhancement Module: warn
Projects
Deployment
Deployed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hamishzx @Xi-Plus