Improve compose traverse perf #380
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wismill
added
compose
wismill
force-pushed
the
compose/traverse-perf
branch
from
a27b66c
to
787f16f
Compare
- Allow to switch implementations (TODO: remove) - Restore foreach implementation for benchmark - New implementation without explicit direction
wismill
force-pushed
the
compose/traverse-perf
branch
from
787f16f
to
1bd744d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up of #367 (see the motivation). The aim is to explore better implementations of the compose traversal API, in particular
xkb_compose_table_iterator_next.Currently it is in the state of #367 before removing alternative implementation and squashing. It will need to be rebased once #367 is merged.DoneThere are currently 3 implementations (see the benchmarks), but the aim is to keep the 3rd implementation.