Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add pytest workflow #63

Merged
merged 3 commits into from
Jun 3, 2023
Merged

Conversation

corytodd
Copy link
Collaborator

@corytodd corytodd commented Jun 3, 2023

Enabled testing a range of Python versions on Ubuntu and Windows.

This will help prevent problems like #62 at least until June 19th [1]. A follow up PR
should do one of the following:

  • stop supporting Python 2 (v2.0.0 could be the cutoff, i.e. bump to v3)
  • use the community maintained Docker image mentioned in [1]

[1] actions/setup-python#672

Enabled testing a range of Python versions on Ubuntu and Windows.

Signed-off-by: Cory Todd <cory.todd@canonical.com>
@fzumstein
Copy link
Member

Thanks a lot! Do you mind doing the following changes:

  • Delete .travis.yml
  • Remove python 2.7 and 3.7 (EOL this month) from the tests?

Cory Todd added 2 commits June 3, 2023 10:06
Drop 2.7 and 3.7 from Github Actions ci. Drop Travis entirely in favor
of Github Actions.

Signed-off-by: Cory Todd <cory.todd@canonical.com>
Do not advertise support for Python 2 in the packaging manifest.

Signed-off-by: Cory Todd <cory.todd@canonical.com>
@corytodd
Copy link
Collaborator Author

corytodd commented Jun 3, 2023

Done. I left the python 2 str compat in init.py as a follow up task since that will officially break things.

@fzumstein fzumstein merged commit aa55a7f into xlwings:master Jun 3, 2023
@corytodd corytodd deleted the github-actions branch June 3, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants