Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xpack: wix toolset support #4788

Draft
wants to merge 13 commits into
base: dev
Choose a base branch
from
Draft

Xpack: wix toolset support #4788

wants to merge 13 commits into from

Conversation

A2va
Copy link
Contributor

@A2va A2va commented Mar 1, 2024

Closes #4637

TODO:

  • Add to PATH
  • Add xpack components
  • Submit package to xmake-repo

There are two drawbacks:

  • From what I have learned with the wix toolset, you cannot set the order of the actions (installing files, creating folders). So the commands set in before_installcmd or after_installcmd can be executed at the same time.
  • The actions that wix can perform are limited, so the move and cd commands are not supported.

@waruqi waruqi mentioned this pull request May 16, 2024
@waruqi
Copy link
Member

waruqi commented May 23, 2024

Does it ready now?

@A2va
Copy link
Contributor Author

A2va commented May 23, 2024

There are a few things missing (unit tests, ...), I will test again tomorrow and the review can be done this weekend.
If anyone wants to try and provide feedback, I will be happy to take it.

@waruqi
Copy link
Member

waruqi commented May 23, 2024

you can add this new format in test.

set_formats("nsis", "srpm", "rpm", "zip", "targz", "srczip", "srctargz", "runself")

it will be tested on ci.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants