fix(dom): prevent iteration over deleted items #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
@qtow from what I understood in your issue report, this should fix it in all the ways I could think of. Do you have a way to verify it before landing the PR? Or would you suggest to add any test? If you are not able to, I can land and release it as part of the next pre-release for 0.9.0 and once you verified that, I would provide a backports for the versions 0.8 and 0.7 |
karfau
added a commit
that referenced
this pull request
Jul 19, 2023
- `NodeList.item` now checks the `length` attribute before accessing the item at a provided index and returns `null` it the index is out of range - when updating `LiveNodeList` (as part of accessing the `item` method) and the new `length` is shorter then the current one, any references on indexes following the index starting from `length` are `delete`d, and `null` is returned instead of `undefined` - added some exports to the `lib/dom.js` module to enable testing fixes #499
karfau
added a commit
that referenced
this pull request
Jul 19, 2023
- `NodeList.item` now checks the `length` attribute before accessing the item at a provided index and returns `null` it the index is out of range - when updating `LiveNodeList` (as part of accessing the `item` method) and the new `length` is shorter then the current one, any references on indexes following the index starting from `length` are `delete`d, and `null` is returned instead of `undefined` - added some exports to the `lib/dom.js` module to enable testing fixes #499
|
The fix landed in 0.7 (lts), 0.8 (latest) and 0.9 (next) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NodeList.itemnow checks thelengthattribute before accessing the item at a provided index and returnsnullit the index is out of rangeLiveNodeList(as part of accessing theitemmethod) and the newlengthis shorter then the current one, any references on indexes following the index starting fromlengtharedeleted, andnullis returned instead ofundefinedlib/dom.jsmodule to enable testingfixes #499