Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move from deprecated ESLint.CLIEngine to ESLint #534

Merged
merged 14 commits into from May 9, 2021
Merged

Move from deprecated ESLint.CLIEngine to ESLint #534

merged 14 commits into from May 9, 2021

Conversation

Richienb
Copy link
Contributor

@Richienb Richienb commented Apr 27, 2021 •
edited

@sindresorhus
Copy link
Member

Thanks for working on this ❤️

@sindresorhus
Copy link
Member

I was hoping switching to the new API would make it possible to npm link XO again, but seems not:

~/dev/oss/xo pr/534
❯ npm link

~/dev/oss/xo pr/534
❯ cd ../chalk

~/dev/oss/chalk
❯ npm link xo

~/dev/oss/chalk
❯ xo
Error: Failed to load config "xo" to extend from.
Referenced from: BaseConfig
    at configInvalidError (/Users/sindresorhus/dev/oss/xo/node_modules/@eslint/eslintrc/lib/config-array-factory.js:290:9)
    at ConfigArrayFactory._loadExtendedShareableConfig (/Users/sindresorhus/dev/oss/xo/node_modules/@eslint/eslintrc/lib/config-array-factory.js:883:23)
    at ConfigArrayFactory._loadExtends (/Users/sindresorhus/dev/oss/xo/node_modules/@eslint/eslintrc/lib/config-array-factory.js:781:25)
    at ConfigArrayFactory._normalizeObjectConfigDataBody (/Users/sindresorhus/dev/oss/xo/node_modules/@eslint/eslintrc/lib/config-array-factory.js:720:25)
    at _normalizeObjectConfigDataBody.next (<anonymous>)
    at ConfigArrayFactory._normalizeObjectConfigData (/Users/sindresorhus/dev/oss/xo/node_modules/@eslint/eslintrc/lib/config-array-factory.js:665:20)
    at _normalizeObjectConfigData.next (<anonymous>)
    at ConfigArrayFactory.create (/Users/sindresorhus/dev/oss/xo/node_modules/@eslint/eslintrc/lib/config-array-factory.js:460:16)
    at createBaseConfigArray (/Users/sindresorhus/dev/oss/xo/node_modules/@eslint/eslintrc/lib/cascading-config-array-factory.js:98:48)
    at new CascadingConfigArrayFactory (/Users/sindresorhus/dev/oss/xo/node_modules/@eslint/eslintrc/lib/cascading-config-array-factory.js:234:30)

@Richienb
Use object destructuring
c21ffd6 
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
@Richienb
Merge branch 'move-to-eslint' of https://github.com/Richienb/xo into …
a004a5f 
…move-to-eslint
@xojs xojs deleted a comment from codecov-commenter Apr 28, 2021
@sindresorhus
Copy link
Member

How are you manually testing this when npm link doesn't work? We cannot really trust only the tests as they're not comprehensive enough.

sindresorhus
sindresorhus requested changes Apr 28, 2021
View reviewed changes
lib/options-manager.js Outdated Show resolved Hide resolved
@codecov-commenter

This comment has been minimized.

Sign in to view
@Richienb
Use public API to access normalizePackageName
e97b604 
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
@Richienb
Resolve absolute paths of modules in options.extends
be280f3 
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
@Richienb
Copy link
Contributor Author

Richienb commented May 8, 2021

How are you manually testing this when npm link doesn't work? We cannot really trust only the tests as they're not comprehensive enough.

I was using XO to lint its own codebase which doesn't suffer from these directory problems.

@Richienb Richienb requested a review from sindresorhus May 8, 2021 14:22
@sindresorhus
Copy link
Member

This seems to be working well. Really nice work, @Richienb 🙌

@sindresorhus sindresorhus merged commit 0480d80 into xojs:main May 9, 2021
@luludotdev luludotdev mentioned this pull request May 14, 2021
Closed
@vikaspotluri123 vikaspotluri123 mentioned this pull request Jul 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus Awaiting requested review from sindresorhus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move from deprecated ESLint.CLIEngine
3 participants
@Richienb @sindresorhus @codecov-commenter