New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add XONSH_PIPEFAIL option to raise on piped subproc failure #5239
base: main
Are you sure you want to change the base?
Conversation
Ahh tests failed on Windows. I'll change this to a draft while I figure that out :) |
hi @Qyriad! Thank you for this! |
Ah, the test problem turned out to be really simple. Re: docs, that's a great idea yes, I'll work on that |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5239 +/- ##
==========================================
- Coverage 67.17% 67.15% -0.03%
==========================================
Files 119 119
Lines 23116 23134 +18
Branches 4853 4859 +6
==========================================
+ Hits 15529 15535 +6
- Misses 6383 6394 +11
- Partials 1204 1205 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Let me know how that documentation looks. If everything looks good I'll rebase this |
Looks nice! Please add the mention also into https://github.com/xonsh/xonsh/blob/main/docs/bash_to_xsh.rst |
Hey! Is it ready to review? Nice feature! |
Closes #4351.
Let me know if there's a better way to implement or test this, and feel free to bikeshed the option name, of course.
For community
⬇️ Please click the 👍 reaction instead of leaving a
+1
or 👍 comment