Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: types exports for modern TypeScript bundling #22

Merged
merged 1 commit into from Mar 3, 2024

Conversation

Cherry
Copy link
Contributor

@Cherry Cherry commented Dec 12, 2023

When using modern TypeScript configurations, such as with moduleResolution: bundler, the types field in the package.json is ignored when exports is specified.

This PR simply adds types to the exports definition, so TypeScript types load as expected.

@xpl xpl merged commit e0a7fd1 into xpl:master Mar 3, 2024
@Cherry Cherry deleted the fix/types-exports branch March 3, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants