New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional jsHandle.uploadFile event #105

Merged

xvrh merged 2 commits into xvrh:master from kendalsickels-wf:fileUploadFix

Feb 25, 2020

Collaborator

kendalsickels-wf commented Feb 24, 2020 •

edited

jsHandle.uploadFile was not working in all cases. Adding an additional event with type of change resolves one of those issues.

kendalsickels-wf added 2 commits

February 24, 2020 11:40


          Change event type from input to change

3f6f340


          Instead of modifying the event add an additional event

ffbb44b

kendalsickels-wf changed the title ~~Change jsHandle.uploadFile event type~~ Add additional jsHandle.uploadFile event

kendalsickels-wf mentioned this pull request

uploadFile no longer works #99

Closed

Owner

xvrh commented Feb 25, 2020

Perfect. Thanks for the contribution!
There is the same change in fly in the puppeteer repository: puppeteer/puppeteer#5389

xvrh merged commit 8678d6c into xvrh:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment