Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix navigation error #312

Merged
merged 8 commits into from
May 17, 2024
Merged

Fix navigation error #312

merged 8 commits into from
May 17, 2024

Conversation

kendalsickels-wf
Copy link
Collaborator

@kendalsickels-wf kendalsickels-wf commented May 15, 2024

@xvrh We've started to see an issue similar to #237 in our tests. I was able to create a test that fails consistently without any changes committed.

Then committed some changes that work around the issue but I'm lacking the context that you likely have over the entirety of this project to say if those changes would cause issues elsewhere.

I operated under the assumption that in the _onExecutionContextsCleared scenario we should go quietly into the night instead of erroring and _onExecutionContextsDestroyed we should error. But perhaps that was a poor assumption. Looking for any guidance/insight you might have on how to solve this issue.

Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 5 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (master@3fe1eeb). Click here to learn what that means.

Files Patch % Lines
lib/src/page/dom_world.dart 69.23% 4 Missing ⚠️
lib/src/page/frame_manager.dart 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #312   +/-   ##
=========================================
  Coverage          ?   88.80%           
=========================================
  Files             ?       32           
  Lines             ?     3172           
  Branches          ?        0           
=========================================
  Hits              ?     2817           
  Misses            ?      355           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xvrh xvrh marked this pull request as ready for review May 17, 2024 17:00
@xvrh xvrh merged commit 37f4532 into master May 17, 2024
6 checks passed
@xvrh xvrh deleted the context-disposed-fix branch May 17, 2024 17:00
@xvrh
Copy link
Owner

xvrh commented May 17, 2024

Thanks for the contribution. I'll merge it as it: all the tests are passing and it seems to fix already some other issues (like #314)

xvrh pushed a commit that referenced this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants