-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix navigation error #312
Fix navigation error #312
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #312 +/- ##
=========================================
Coverage ? 88.80%
=========================================
Files ? 32
Lines ? 3172
Branches ? 0
=========================================
Hits ? 2817
Misses ? 355
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Thanks for the contribution. I'll merge it as it: all the tests are passing and it seems to fix already some other issues (like #314) |
@xvrh We've started to see an issue similar to #237 in our tests. I was able to create a test that fails consistently without any changes committed.
Then committed some changes that work around the issue but I'm lacking the context that you likely have over the entirety of this project to say if those changes would cause issues elsewhere.
I operated under the assumption that in the
_onExecutionContextsCleared
scenario we should go quietly into the night instead of erroring and_onExecutionContextsDestroyed
we should error. But perhaps that was a poor assumption. Looking for any guidance/insight you might have on how to solve this issue.