XWIKI-22037 AWM Display as hidden field should not be displayed #3043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add support to hidden type in Content and Title custom display * Factorize code between edit and hidden mode
lucaa
requested changes
Apr 10, 2024
...inminutes/xwiki-platform-appwithinminutes-ui/src/main/resources/AppWithinMinutes/Content.xml
Outdated
Show resolved
Hide resolved
...thinminutes/xwiki-platform-appwithinminutes-ui/src/main/resources/AppWithinMinutes/Title.xml
Outdated
Show resolved
Hide resolved
* Put var assignation into 'if' * Revert var name change
|
Hello, Did the requested changes. |
lucaa
requested changes
May 12, 2024
...inminutes/xwiki-platform-appwithinminutes-ui/src/main/resources/AppWithinMinutes/Content.xml
Outdated
Show resolved
Hide resolved
* Factorize html macro
lucaa
requested changes
May 14, 2024
...inminutes/xwiki-platform-appwithinminutes-ui/src/main/resources/AppWithinMinutes/Content.xml
Show resolved
Hide resolved
* Fix $id definition in hidden mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-22037
Changes
Description
if)Clarifications
Executed Tests
It's mainly the same process than to reproduce the issue described here: https://jira.xwiki.org/browse/XWIKI-22037
Tested by creating a new App with AWM and edited the
title1andcontent1field on the generated sheet to show as hidden. Than tested that theses field are correctly hidden.Expected merging strategy