XWIKI-16986: No incorrect message appears when adding a wrong Captcha #3054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rely on the actual RegisterAction when using the standard
Registration page
* Fix issue with the redirect parameter in RegisterAction which causes
it to always redirect, even in case of error
* Refactor Registration page to immediately display an error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-16986
Changes
Description
Honestly I'm not entirely sure about those changes, in particular about possible regressions with custom fields...
Clarifications
Screenshots & Video
Executed Tests
Ran
mvn clean install -Dit.test=RegisterITon administration module andmvn clean install -Pqualityon oldcore module.Now we're probably missing integration tests with captcha.
Expected merging strategy