XWIKI-22120: Live Data links are underlined although 'Underline links' setting is set to 'Only Inline Links' #3085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…' setting is set to 'Only Inline Links' * Added an exception in the only inline link rules to not underline links in link displays in livedatas. * Updated the UserDisplay velocity template: ** Replaced the alt from the picture (which was repetitive with the text after). This user avatar does not convey any specific meaning, and similarly to icons it should be indicated that it is semantically irrelevant. ** Moved the avatar inside of the link. This provides multiple benefits one of which is that now the link hits the `:has(img)` selector to prevent underlining :)
surli
reviewed
May 15, 2024
| @@ -318,10 +318,12 @@ $xwiki.getUserName("xwiki:${username}") | |||
| ## We avoid the whitespace because the users are displayed as inline blocks. | |||
| #set ($discard = $output.addAll([ | |||
| "<$userTag class=""$type"" data-reference=""$escapetool.xml($userReference)"">", | |||
| "<$userNameTag $userNameTagAttributes>", | |||
There was a problem hiding this comment.
This change feels a bit dangerous: you're changing the DOM for the display of #displayUser which is a very used macro. It's probably harmless but at the very least I would run a few integration tests, maybe flamingo-skin-test-docker.
And we probably should discuss such change in the future.
There was a problem hiding this comment.
Couldn't you match the user-name or group-name class attribute instead of modifying the HTML?
michitux
reviewed
May 15, 2024
| @@ -175,7 +175,8 @@ body.content { | |||
| & .xtree, | |||
| & .xwikitabbar, | |||
| & .buttonwrapper, | |||
| & #user-menu-col { | |||
| & #user-menu-col, | |||
| & .xwiki-livedata .cell .displayer-link { | |||
There was a problem hiding this comment.
So the breadcrumb in the location column in Live Data would remain underlined? Seems inconsistent to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-22120
Changes
Description
** Replaced the user avatar alternative text.
** Moved the avatar inside of the link. This provides multiple benefits one of which is that now the link hits the
:has(img)selector to prevent underlining :)Clarifications
altproperty on the picture.** the avatar can now be clicked to follow the link.
** the link hits the
:has(img)selector to prevent underlining :) This selector is quite generic and added for cases such as this one :)Screenshots & Video
All screenshots here display UI examples after the changes proposed in this PR. The current user is the wiki admin and has the
Only inline linkunderlining preference selected.We can see that the reported issue is solved, the links in the table are not underlined anymore :)
The change to the structure of the DisplayUser template might break some UI. However we can see here that this UI relying on an avatar wrapper is doing alright. Note that most of the styles about this template come from
xwiki-platform/xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-resources/src/main/resources/flamingo/less/users.less
Line 17 in 7e9ccc5
>direct child operators, so moving the avatar down a level does not break any selector here).Executed Tests
Manual tests with Firefox as seen above.
Expected merging strategy