XWIKI-22138: Tips panel does not have underline style for links in subwiki #3094
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-22138
Changes
Description
class contains
selectorClarifications
contains
boolean that would not be possible to do with the.
notation.HelpTipsPanel
. This makes sure we don't match any panel in a wiki that would haveHelpTipsPanel
for ID. I think the selector as it is now is robust enough. It's not perfect and could still be matched unexpectedly in some very niche situations e.g., using a panel with an ID which contains the stringHelpTipsPanel
.Screenshots & Video
Before the changes proposed in this PR
After the changes proposed in this PR
Executed Tests
Style changes only, tested manually on a local distribution with:
See the screenshots above. After updating the color theme (reloading the LESS content from the updated general.less), we could witness that the anchors are properly hit by the new css selector.
Expected merging strategy