XWIKI-22148: The search results are not hidden when the focus moves out of the quick search field

[manuelleduc]

Jira URL

https://jira.xwiki.org/browse/XWIKI-22148

Changes

Description

• Define a css selector for the search results when the focus is out of the search field
• Define a transition when the search results get hidden (I'm not really satisfied of the result for now, if somebody has a suggestion for improvement, @tkrieck maybe?)

Screenshots & Video

Screencast.from.06-05-2024.15.44.39.webm

Executed Tests

Manual tests.

Expected merging strategy

• Prefers squash: Yes
• Backport on branches:
  • stable-16.3.x
  • stable-15.10.x

[tkrieck]

The animation is a bit awkward because the results are being positioned relative to the left of the bounding box (with a negative value). So when the input is shrunk to 0 the result box follow this change in size from the left margin. The animation will be nicer if you could change it to the right and with a positive number (this will be the size of the search icon bounding box).

I don't know the complexity of this because I did it only in web tools.

Before:

After:

Animation with the change:

Screen.Recording.2024-05-06.at.13.19.05.mp4

[manuelleduc]

I don't know the complexity of this because I did it only in web tools.

Seems a bit complicated, changing the positioning the way you suggest implies changing the positioning logic of XWiki.widgets.Suggest (see

xwiki-platform/xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war/src/main/webapp/resources/uicomponents/suggest/suggest.js

Line 513 in 78728c9

if (this.options.align == 'left' || (this.options.align == 'auto' && inputPositionLeft + this.options.width < browserWidth)) {

) which feels a bit risky for a bugfix.

Another option is to simply not have any animation, I feel like it's nicer to just see the results disappear instantaneously than to have an inconsistent animation.
WDYT?

[tkrieck]

I don't know the complexity of this because I did it only in web tools.

Seems a bit complicated, changing the positioning the way you suggest implies changing the positioning logic of XWiki.widgets.Suggest (see

xwiki-platform/xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war/src/main/webapp/resources/uicomponents/suggest/suggest.js

Line 513 in 78728c9

if (this.options.align == 'left' || (this.options.align == 'auto' && inputPositionLeft + this.options.width < browserWidth)) {

) which feels a bit risky for a bugfix.
Another option is to simply not have any animation, I feel like it's nicer to just see the results disappear instantaneously than to have an inconsistent animation. WDYT?

I was not aware of the logic behind it. In that case I agree that disabling the animation seems to be the best option.