fix pattern position (#212) #223
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielBretzigheimer
force-pushed
the
feature/svg_pattern_fixed_#212
branch
2 times, most recently
from
b2e2a3b
to
9e9d4d5
Compare
|
I've added a test case for the pattern offset fix |
DanielBretzigheimer
force-pushed
the
feature/svg_pattern_fixed_#212
branch
from
9e9d4d5
to
ee044f1
Compare
|
Fixed second point of my comment. |
DanielBretzigheimer
force-pushed
the
feature/svg_pattern_fixed_#212
branch
from
ee044f1
to
530af8e
Compare
|
Could part of the issue be similar to parallax/jsPDF#3627? Or the respective svg2pdf issue #244? If that's the case then I think we should fix the unit-scaling-related part on jsPDF side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have (hopefully) resolved the problem of the pattern not starting at the right position. The other issues. I tried fixing the other two issues mentioned by me here, but haven't found a solution yet.
Maybe someone else has an idea or a hint :)