Test with graphql-js v15.0.0-rc.1 #32
Comments
|
One change that I think will be breaking for graphql-tools (now "fixed" in the fork's v15 branch) is that buildSchema used to ignore extensions, but now parses them. graphql-tools used to pass the extensions to buildSchema and then call extendSchema, but in v15 this will fail as the extensions are already added. graphql/graphql-js#2248 This is labelled as a new feature (which it is!) but possibly should also be considered a breaking change, which it will be for graphql-tools (although not the fork). If that makes sense! |
|
@IvanGoncharov, looks good from here. Users can install the prerelease of graphql-tools-fork v9 with graphql v15.0.0-rc.1 support via npm using the below amazing label: |
@yaacovCR Yes, indeed 👍 I will update the changelog to mark it as breaking. |
.@IvanGoncharov originally brought this to my attention when he pointed me to yaacovCR#32 (comment) and suggested stripping extension nodes prior to invoking `buildASTSchema` as a cross-version (v14 <=> v15) approach for interim compatibility on the v4 series of `graphql-tools`. The most urgent and pertinent need here from my perspective is to allow user-exploration of the new `graphql@15` release candidate within Apollo Server which currently re-exports the entirety of `graphql-tools` (even though it only relies on small portions of it). Upon further investigation of the above-referenced issue, it appears that @yaacovCR had already crafted the solution that @IvanGoncharov had suggested to me, which I found in 2280eef within the well-organized #1206 (which I am thankful for the continued updates on!). My commit here merely grabs a sub-set of that commit that seemed most pertinent; I certainly don't claim that this solution is nearly as comprehensive as the original 2280eef. My hope is that by using the same code/implementation here, it will marginally lessen future merge conflicts. Since this is basically a re-working of @yaacovCR's commit, I've attributed co-authorship of this commit accordingly. (Thank you, again!) Ref: #1272 Co-authored-by: yaacovCR <yaacovCR@gmail.com>
…1284) * Inline `PrintSchemaOptions` type, whose parent module has been moved. This option will likely be deprecated in `graphql@16`. For now, we'll inline this type into this module to continue emitting it into the declaration file for `makeRemoteExecutableSchema`. This is necessary since the TypeScript compiler can no longer resolve its previous location as `graphql` has moved the location of the `schemaPrinter` module to `printSchema` in graphql/graphql-js#2426. cc @IvanGoncharov * Fix incompatibility between `iterall` and newer TypeScript types. This wouldn't be necessary if this project had a `package-lock.json`, but... * compat: filter extensions prior to passing to `buildASTSchema`. .@IvanGoncharov originally brought this to my attention when he pointed me to yaacovCR#32 (comment) and suggested stripping extension nodes prior to invoking `buildASTSchema` as a cross-version (v14 <=> v15) approach for interim compatibility on the v4 series of `graphql-tools`. The most urgent and pertinent need here from my perspective is to allow user-exploration of the new `graphql@15` release candidate within Apollo Server which currently re-exports the entirety of `graphql-tools` (even though it only relies on small portions of it). Upon further investigation of the above-referenced issue, it appears that @yaacovCR had already crafted the solution that @IvanGoncharov had suggested to me, which I found in 2280eef within the well-organized #1206 (which I am thankful for the continued updates on!). My commit here merely grabs a sub-set of that commit that seemed most pertinent; I certainly don't claim that this solution is nearly as comprehensive as the original 2280eef. My hope is that by using the same code/implementation here, it will marginally lessen future merge conflicts. Since this is basically a re-working of @yaacovCR's commit, I've attributed co-authorship of this commit accordingly. (Thank you, again!) Ref: #1272 Co-authored-by: yaacovCR <yaacovCR@gmail.com> * Add CHANGELOG for #1284. Co-authored-by: Yaacov Rydzinski <yaacovCR@gmail.com>
Hi @yaacovCR
I plan to release long overdue graphql-js v15.0.0
It includes a number of small breaking changes:
https://github.com/graphql/graphql-js/releases/tag/v15.0.0-alpha.1
https://github.com/graphql/graphql-js/releases/tag/v15.0.0-alpha.2
https://github.com/graphql/graphql-js/releases/tag/v15.0.0-rc.1
Since your fork uses a lot of public APIs from
graphql-jsit would be great if you can try15.0.0-rc.1and report back problems if any.The text was updated successfully, but these errors were encountered: