Skip to content
This repository has been archived by the owner on Apr 15, 2020. It is now read-only.

GraphQL v15 support #39

Closed
wants to merge 2 commits into from
Closed

GraphQL v15 support #39

wants to merge 2 commits into from

Conversation

ardatan
Copy link

@ardatan ardatan commented Feb 3, 2020

  • Do not extend if the node is already extended (GraphQL v15 does that internally)
  • Do not use introspectionQuery which is deprecated and removed in v15
  • Fix asyncIterator typing

@yaacovCR
Copy link
Owner

yaacovCR commented Feb 3, 2020

See #32

Do you have any suggestions for supporting both v14 and v15. I imagine I will need to release a major version change (I am up to v8.5, so v9?) with the changes from #32 and then would have to backport any fixes to a V8 branch.

@ardatan
Copy link
Author

ardatan commented Feb 3, 2020

I think those changes already support both v14 and v15. They are not only for v15.
getIntrospectionQuery is already introduced in v14, and changes about extensions check if extensions are included in actual astNode not to break anything on v14.

@yaacovCR
Copy link
Owner

yaacovCR commented Feb 3, 2020

I think because there are breaking changes anyway between v14 and v15 that it is better/cleaner to fix extensions issues as in a3aadcf rather than with check for existence of extension nodes after buildSchema. Do you disagree?

@yaacovCR
Copy link
Owner

See also #40

@yaacovCR yaacovCR closed this Feb 14, 2020
@ardatan
Copy link
Author

ardatan commented Feb 14, 2020

I think those changes can be applied for both v14 and v15. I think supporting both versions would be better than having different releases for each. @yaacovCR

@yaacovCR yaacovCR reopened this Feb 14, 2020
@yaacovCR
Copy link
Owner

This is addressed in graphql-tools-fork v8.6.0 which supports:
graphql v14.2.0 and above
graphql v15.0.0-rc2 and above

@yaacovCR yaacovCR closed this Feb 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants