Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add importlib-metadata constraint to avoid celery import bug #90

Merged
merged 6 commits into from
Feb 9, 2023

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Feb 9, 2023

Resolves #89

  • Fix requires a new release of kombu
  • This should be viewed as temporary. As soon as there is a new release of kombu the release with this fix in in should get yanked in favor of a new release without this restriction.
  • Add lower bound of celery>=5.0.0.
* Fix requires a new release of kombu
   - c.f. https://github.com/celery/celery/issues/7783#issuecomment-1283638046
   - This should be viewed as temporary. As soon as there is a new release of kombu
     the release with this fix in in should get yanked in favor of a new release
     without this restriction.
* Add lower bound of celery>=5.0.0.

@matthewfeickert matthewfeickert self-assigned this Feb 9, 2023
"celery": [
"celery>=5.0.0",
"redis",
"importlib-metadata<5.0.0; python_version < '3.8'", # FIXME: c.f. https://github.com/celery/celery/issues/7783
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Celery should be monitored for a new release that will remove the need for this constraint.

@matthewfeickert matthewfeickert merged commit e4b202d into master Feb 9, 2023
@matthewfeickert matthewfeickert deleted the fix/workaround-celery-importlib-bug branch February 9, 2023 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests fail on Celery for Python 3.7 only
1 participant