TypeError: Cannot read property 'name' of undefined in jsx-no-target-blank

[green-arrow]

I'm getting this error after upgrading react-scripts to the latest version. Example code:

<a target="_blank" rel="noreferrer noopener" href="https://www.example.com">

The source line from the error is line 28, where it does attr.name.name.

[ljharb]

That's an unclosed element; what's the full source?

[green-arrow]

Sorry about that, here's the full source:

<a
  {...css(
    styles.muted,
    styles.footerItem,
    styles.fullWidthOnMobile
  )}
  target="_blank"
  rel="noopener noreferrer"
  href="https://www.company.com/about"
>
  about company
</a>

[green-arrow]

FWIW, I can't replicate this on a freshly created create-react-app. It only occurs after upgrading from 1.0.4 to 1.0.10.

[ljharb]

Any chance the upgrade isn't bumping eslint-plugin-react? If you do the upgrade and then npm install eslint-plugin-react, what happens?

[green-arrow]

I compared yarn.lock files between a fresh app and my upgraded one, and the version numbers for eslint and eslint-plugin-react match up between the two.

Here is the result of upgrading react-scripts:

It looks like eslint-plugin-react was updated to the latest version alright.

When running npm install eslint-plugin-react after doing the upgrade above, I still get the TypeError.

[ljharb]

It's likely the spread that's doing it.

[ljharb]

Can you confirm by removing it temporarily?

[green-arrow]

@ljharb - you're completely right, removing the spread on css fixes the issue.

Any way to work around this?

Edit: I can workaround this for now by using a different method of passing styles. Not sure if there's any way to work around this that lets you keep the spread.

[ljharb]

I don't think there's a workaround short of disabling the rule entirely for that file.

[jseminck]

Working on a fix.

[green-arrow]

Thanks for the fix, you all are awesome! 😄