Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forbid-prop-types: propWrapperFunctions does not follow identifiers #1352

Closed
ljharb opened this issue Aug 10, 2017 · 3 comments
Closed

forbid-prop-types: propWrapperFunctions does not follow identifiers #1352

ljharb opened this issue Aug 10, 2017 · 3 comments

Comments

@ljharb
Copy link
Member

ljharb commented Aug 10, 2017

I fixed a crash from #1253 in 5ad93b4.

However, see the TODO - the rule (prop-types also) is not following the identifier reference when it's not inline. It should.

cc @dustinsoftware

@ljharb
Copy link
Member Author

ljharb commented Aug 10, 2017

@yannickcr 5ad93b4 is a crasher, so it'd be good to cut a quick patch release with that in it :-)

@dustinsoftware
Copy link
Contributor

dustinsoftware commented Aug 10, 2017 via email

dustinsoftware pushed a commit to dustinsoftware/eslint-plugin-react that referenced this issue Aug 11, 2017
This fixes incorrect behavior when propTypes were stored in a variable and then referenced later. jsx-eslint#1352
dustinsoftware pushed a commit to dustinsoftware/eslint-plugin-react that referenced this issue Aug 11, 2017
This fixes incorrect behavior when propTypes were stored in a variable and then referenced later. jsx-eslint#1352
dustinsoftware pushed a commit to dustinsoftware/eslint-plugin-react that referenced this issue Aug 11, 2017
This fixes incorrect behavior when propTypes were stored in a variable and then referenced later. jsx-eslint#1352
dustinsoftware pushed a commit to dustinsoftware/eslint-plugin-react that referenced this issue Aug 11, 2017
This fixes incorrect behavior when propTypes were stored in a variable and then referenced later. jsx-eslint#1352
@yannickcr
Copy link
Member

@ljharb yep, I'll do a patch release shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants