Issue #1686 - jsx-handler-names: false positive when handler name begins with number #1689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th number Fixes #1686.
ljharb
reviewed
Feb 18, 2018
|
I adjusted the regex so that a capital letter is still required at some point after the word "handle" and added more test cases to demonstrate that minimum requirement. |
ljharb
reviewed
Feb 19, 2018
tests/lib/rules/jsx-handler-names.js
Outdated
| errors: [{message: 'Handler function for onChange prop key must begin with \'handle\''}] | ||
| }, { | ||
| code: '<TestComponent onChange={this.handle4change} />', | ||
| errors: [{message: 'Handler function for onChange prop key must begin with \'handle\''}] |
There was a problem hiding this comment.
hm, we should probably change the error message to add " and be in camelCase", otherwise this one's pretty confusing
There was a problem hiding this comment.
I updated the error message to be more specific and removed the handleC test case that does pass, but should not be considered valid.
There was a problem hiding this comment.
if the test wrongly passes, we should move it to the "invalid" section, even if it's commented out for now.
ljharb
approved these changes
Feb 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated unit test and EVENT_HANDLER_REGEX regex.