New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix static propTypes handling in no-typos #1827
Fix static propTypes handling in no-typos #1827
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add duplicate test cases that do not use babel-eslint (ie, using Component.propTypes =
)?
(if those test cases already exist - because the bug is about class fields - then my bad) |
@ljharb I think these two cases are what you're looking for? I don't think these need |
That’s be great - generally it’s nice to have every test case repeated, one for each parser. |
@@ -45,7 +45,7 @@ module.exports = { | |||
let propTypesPackageName = null; | |||
let reactPackageName = null; | |||
|
|||
function checkValidPropTypeQualfier(node) { | |||
function checkValidPropTypeQualifier(node) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Someone put typos in no-typos
so I can fix typos while I fix no-typos
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -45,7 +45,7 @@ module.exports = { | |||
let propTypesPackageName = null; | |||
let reactPackageName = null; | |||
|
|||
function checkValidPropTypeQualfier(node) { | |||
function checkValidPropTypeQualifier(node) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This Pull Request updates dependency [eslint-plugin-react](https://github.com/yannickcr/eslint-plugin-react) from `v7.9.1` to `v7.10.0` <details> <summary>Release Notes</summary> ### [`v7.10.0`](https://github.com/yannickcr/eslint-plugin-react/blob/master/CHANGELOG.md#​7100---2018-06-24) [Compare Source](jsx-eslint/eslint-plugin-react@v7.9.1...v7.10.0) ##### Added * Allow eslint ^5 ([#​1843][] @​papandreou, @​ljharb) * [`no-unsafe`][] rule ([#​1831][], [#​1830][] @​sergei-startsev) * [`no-will-update-set-state`][]: Account for `UNSAFE_` methods ([#​1845][], [#​1844][] @​alexzherdev) ##### Fixed * [`no-typos`][]: Fix static propTypes handling ([#​1827][], [#​1677][] @​alexzherdev) * [`destructuring-assignment`][]: Allow LHS ([#​1825][], [#​1728][] @​alexzherdev) * [`no-unused-prop-types`][]: Fix crash when encountering mixed union and intersection flow types ([#​1806][] @​yannickcr) ##### Changed * Typo fixes in [`jsx-no-target-blank`][] ([#​1805][] @​ferhatelmas)) [#​1845]: `jsx-eslint/eslint-plugin-react#1845 [#​1844]: `jsx-eslint/eslint-plugin-react#1844 [#​1843]: `jsx-eslint/eslint-plugin-react#1843 [#​1831]: `jsx-eslint/eslint-plugin-react#1831 [#​1830]: `jsx-eslint/eslint-plugin-react#1830 [#​1827]: `jsx-eslint/eslint-plugin-react#1827 [#​1825]: `jsx-eslint/eslint-plugin-react#1825 [#​1806]: `jsx-eslint/eslint-plugin-react#1806 [#​1805]: `jsx-eslint/eslint-plugin-react#1805 [#​1728]: `jsx-eslint/eslint-plugin-react#1728 [#​1677]: `jsx-eslint/eslint-plugin-react#1677 --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com).
Resolves #1677