Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't depend on state parameter name in no-unused-state #1829

Merged
merged 1 commit into from Oct 1, 2018
Merged

Don't depend on state parameter name in no-unused-state #1829

merged 1 commit into from Oct 1, 2018

Conversation

alexzherdev
Copy link
Contributor

Resolves #1759

@alexzherdev alexzherdev mentioned this pull request Oct 1, 2018
Closed
@ljharb ljharb merged commit d0765dd into jsx-eslint:master Oct 1, 2018
EvHaus
EvHaus reviewed Oct 1, 2018
View reviewed changes
Copy link
Collaborator

@EvHaus EvHaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes. Thanks for this. LGTM

@EvHaus EvHaus self-requested a review October 1, 2018 20:56
@alexzherdev alexzherdev deleted the 1759-state-parameter-names branch October 6, 2018 03:43
@cabarnes cabarnes mentioned this pull request Oct 14, 2018
Merged
@projectyang projectyang mentioned this pull request Oct 16, 2018
Merged
@alexzherdev alexzherdev mentioned this pull request Dec 1, 2018
Closed
NimaSoroush pushed a commit to NimaSoroush/differencify that referenced this pull request Dec 28, 2018
@greenkeeper @NimaSoroush
Update eslint-plugin-react to the latest version 🚀 (#113)
5299142 
## The devDependency [eslint-plugin-react](https://github.com/yannickcr/eslint-plugin-react) was updated from `7.11.0` to `7.12.0`.
This version is **not covered** by your **current version range**.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

---

<details>
<summary>Release Notes for v7.12.0</summary>

<h3>Added</h3>
<ul>
<li><a href="/yannickcr/eslint-plugin-react/blob/v7.12.0/docs/rules/no-typos.md"><code>no-typos</code></a>: Support createClass (<a href="https://urls.greenkeeper.io/yannickcr/eslint-plugin-react/pull/1828" data-hovercard-type="pull_request" data-hovercard-url="/jsx-eslint/eslint-plugin-react/pull/1828/hovercard">#1828</a>, <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=93752" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/alexzherdev">@alexzherdev</a>)</li>
<li>Support detecting React.forwardRef/React.memo (<a href="https://urls.greenkeeper.io/yannickcr/eslint-plugin-react/pull/2089" data-hovercard-type="pull_request" data-hovercard-url="/jsx-eslint/eslint-plugin-react/pull/2089/hovercard">#2089</a>, <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=416773" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/jomasti">@jomasti</a>)</li>
<li><a href="/yannickcr/eslint-plugin-react/blob/v7.12.0/docs/rules/jsx-indent.md"><code>jsx-indent</code></a>: add <code>checkAttributes</code> option for JSX attribute indentation (<a href="https://urls.greenkeeper.io/yannickcr/eslint-plugin-react/pull/2086" data-hovercard-type="pull_request" data-hovercard-url="/jsx-eslint/eslint-plugin-react/pull/2086/hovercard">#2086</a>, <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=416773" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/jomasti">@jomasti</a>)</li>
<li>Change allowed <code>propWrapperFunctions</code> setting values (<a href="https://urls.greenkeeper.io/yannickcr/eslint-plugin-react/pull/2065" data-hovercard-type="pull_request" data-hovercard-url="/jsx-eslint/eslint-plugin-react/pull/2065/hovercard">#2065</a>, <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=416773" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/jomasti">@jomasti</a>)</li>
<li>add <a href="/yannickcr/eslint-plugin-react/blob/v7.12.0/docs/rules/jsx-fragments.md"><code>jsx-fragments</code></a> rule to enforce fragment syntax (<a href="https://urls.greenkeeper.io/yannickcr/eslint-plugin-react/pull/1994" data-hovercard-type="pull_request" data-hovercard-url="/jsx-eslint/eslint-plugin-react/pull/1994/hovercard">#1994</a>, <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=93752" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/alexzherdev">@alexzherdev</a>)</li>
<li>Support "detect" option for React version setting (<a href="https://urls.greenkeeper.io/yannickcr/eslint-plugin-react/pull/1978" data-hovercard-type="pull_request" data-hovercard-url="/jsx-eslint/eslint-plugin-react/pull/1978/hovercard">#1978</a>, <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=93752" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/alexzherdev">@alexzherdev</a>)</li>
<li>Support shorthand fragment syntax in many rules (<a href="https://urls.greenkeeper.io/yannickcr/eslint-plugin-react/pull/1956" data-hovercard-type="pull_request" data-hovercard-url="/jsx-eslint/eslint-plugin-react/pull/1956/hovercard">#1956</a>, <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=93752" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/alexzherdev">@alexzherdev</a>)</li>
<li><a href="/yannickcr/eslint-plugin-react/blob/v7.12.0/docs/rules/jsx-no-literals.md"><code>jsx-no-literals</code></a>: print node value in warning message (<a href="https://urls.greenkeeper.io/yannickcr/eslint-plugin-react/pull/2008" data-hovercard-type="pull_request" data-hovercard-url="/jsx-eslint/eslint-plugin-react/pull/2008/hovercard">#2008</a>, <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=41166517" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/jlgonzalezdev">@jlgonzalezdev</a>)</li>
</ul>
<h3>Fixed</h3>
<ul>
<li><a href="/yannickcr/eslint-plugin-react/blob/v7.12.0/docs/rules/jsx-max-depth.md"><code>jsx-max-depth</code></a>: Fix depth of JSX siblings in a JSXEpressionContainer (<a href="https://urls.greenkeeper.io/yannickcr/eslint-plugin-react/pull/1824" data-hovercard-type="pull_request" data-hovercard-url="/jsx-eslint/eslint-plugin-react/pull/1824/hovercard">#1824</a>, <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=93752" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/alexzherdev">@alexzherdev</a>)</li>
<li><a href="/yannickcr/eslint-plugin-react/blob/v7.12.0/docs/rules/no-array-index-key.md"><code>no-array-index-key</code></a>: fix in React.Children methods (<a href="https://urls.greenkeeper.io/yannickcr/eslint-plugin-react/pull/2085" data-hovercard-type="pull_request" data-hovercard-url="/jsx-eslint/eslint-plugin-react/pull/2085/hovercard">#2085</a>, <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=4298089" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/himynameisdave">@himynameisdave</a>)</li>
<li><a href="/yannickcr/eslint-plugin-react/blob/v7.12.0/docs/rules/no-unused-state.md"><code>no-unused-state</code></a>: handle functional setState (<a href="https://urls.greenkeeper.io/yannickcr/eslint-plugin-react/pull/2084" data-hovercard-type="pull_request" data-hovercard-url="/jsx-eslint/eslint-plugin-react/pull/2084/hovercard">#2084</a>, <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=416773" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/jomasti">@jomasti</a>)</li>
<li>version errors should log to stderr, not stdout (<a href="https://urls.greenkeeper.io/yannickcr/eslint-plugin-react/issues/2082" data-hovercard-type="issue" data-hovercard-url="/jsx-eslint/eslint-plugin-react/issues/2082/hovercard">#2082</a>, <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=45469" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/ljharb">@ljharb</a>)</li>
<li><a href="/yannickcr/eslint-plugin-react/blob/v7.12.0/docs/rules/no-deprecated.md"><code>no-deprecated</code></a>: Disable legacy lifecycle methods linting for now (<a href="https://urls.greenkeeper.io/yannickcr/eslint-plugin-react/pull/2069" data-hovercard-type="pull_request" data-hovercard-url="/jsx-eslint/eslint-plugin-react/pull/2069/hovercard">#2069</a>, <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=748074" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/sergei-startsev">@sergei-startsev</a>)</li>
<li>ensure that react and flow versions can be numbers (<a href="https://urls.greenkeeper.io/yannickcr/eslint-plugin-react/issues/2056" data-hovercard-type="issue" data-hovercard-url="/jsx-eslint/eslint-plugin-react/issues/2056/hovercard">#2056</a>, <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=45469" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/ljharb">@ljharb</a>)</li>
<li><a href="/yannickcr/eslint-plugin-react/blob/v7.12.0/docs/rules/forbid-foreign-prop-types.md"><code>forbid-foreign-prop-types</code></a>: ensure <code>allowInPropTypes</code> option applies to class fields (<a href="https://urls.greenkeeper.io/yannickcr/eslint-plugin-react/pull/2040" data-hovercard-type="pull_request" data-hovercard-url="/jsx-eslint/eslint-plugin-react/pull/2040/hovercard">#2040</a>, <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=191358" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/Sheile">@Sheile</a>)</li>
<li><a href="/yannickcr/eslint-plugin-react/blob/v7.12.0/docs/rules/jsx-wrap-multilines.md"><code>jsx-wrap-multilines</code></a>: catch single missing newlines (<a href="https://urls.greenkeeper.io/yannickcr/eslint-plugin-react/pull/1984" data-hovercard-type="pull_request" data-hovercard-url="/jsx-eslint/eslint-plugin-react/pull/1984/hovercard">#1984</a>, <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=74260" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/MrHen">@MrHen</a>)</li>
<li><a href="/yannickcr/eslint-plugin-react/blob/v7.12.0/docs/rules/jsx-first-prop-new-line.md"><code>jsx-first-prop-new-line</code></a>: Fix for parsers (like TypeScript) (<a href="https://urls.greenkeeper.io/yannickcr/eslint-plugin-react/pull/2026" data-hovercard-type="pull_request" data-hovercard-url="/jsx-eslint/eslint-plugin-react/pull/2026/hovercard">#2026</a>, <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=1865742" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/HauptmannEck">@HauptmannEck</a>)</li>
<li>[<code>jsx-sort-comp</code>][]: Fix fixer in case of more than 10 props (<a href="https://urls.greenkeeper.io/yannickcr/eslint-plugin-react/pull/2012" data-hovercard-type="pull_request" data-hovercard-url="/jsx-eslint/eslint-plugin-react/pull/2012/hovercard">#2012</a>, <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=2770182" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/tihonove">@tihonove</a>)</li>
<li><a href="/yannickcr/eslint-plugin-react/blob/v7.12.0/docs/rules/no-unused-state.md"><code>no-unused-state</code></a> Don't depend on state parameter name ([<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="332959611" data-permission-text="Issue title is private" data-url="jsx-eslint/eslint-plugin-react#1829" data-hovercard-type="pull_request" data-hovercard-url="/jsx-eslint/eslint-plugin-react/pull/1829/hovercard" href="https://urls.greenkeeper.io/yannickcr/eslint-plugin-react/pull/1829">#1829</a>][], <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=93752" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/alexzherdev">@alexzherdev</a>)</li>
<li><a href="/yannickcr/eslint-plugin-react/blob/v7.12.0/docs/rules/no-this-in-sfc.md"><code>no-this-in-sfc</code></a> fix for class properties (<a href="https://urls.greenkeeper.io/yannickcr/eslint-plugin-react/pull/1995" data-hovercard-type="pull_request" data-hovercard-url="/jsx-eslint/eslint-plugin-react/pull/1995/hovercard">#1995</a>, <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=748074" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/sergei-startsev">@sergei-startsev</a>)</li>
<li><a href="/yannickcr/eslint-plugin-react/blob/v7.12.0/docs/rules/no-this-in-sfc.md"><code>no-this-in-sfc</code></a> fix rule behavior for arrow functions inside a class field (<a href="https://urls.greenkeeper.io/yannickcr/eslint-plugin-react/pull/1989" data-hovercard-type="pull_request" data-hovercard-url="/jsx-eslint/eslint-plugin-react/pull/1989/hovercard">#1989</a>, <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=748074" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/sergei-startsev">@sergei-startsev</a>)</li>
<li><a href="/yannickcr/eslint-plugin-react/blob/v7.12.0/docs/rules/destructuring-assignment.md"><code>destructuring-assignment</code></a>: handle nested props usage (<a href="https://urls.greenkeeper.io/yannickcr/eslint-plugin-react/pull/1983" data-hovercard-type="pull_request" data-hovercard-url="/jsx-eslint/eslint-plugin-react/pull/1983/hovercard">#1983</a>, <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=93752" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/alexzherdev">@alexzherdev</a>)</li>
<li><a href="/yannickcr/eslint-plugin-react/blob/v7.12.0/docs/rules/sort-prop-types.md"><code>sort-prop-types</code></a>: fix string property order (<a href="https://urls.greenkeeper.io/yannickcr/eslint-plugin-react/pull/1977" data-hovercard-type="pull_request" data-hovercard-url="/jsx-eslint/eslint-plugin-react/pull/1977/hovercard">#1977</a>, <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=12821094" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/metreniuk">@metreniuk</a>)</li>
<li><a href="/yannickcr/eslint-plugin-react/blob/v7.12.0/docs/rules/jsx-no-target-blank.md"><code>jsx-no-target-blank</code></a>: don’t crash when there’s no value (<a href="https://urls.greenkeeper.io/yannickcr/eslint-plugin-react/issues/1949" data-hovercard-type="issue" data-hovercard-url="/jsx-eslint/eslint-plugin-react/issues/1949/hovercard">#1949</a>, <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=45469" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/ljharb">@ljharb</a>)</li>
<li><a href="/yannickcr/eslint-plugin-react/blob/v7.12.0/docs/rules/prop-types.md"><code>prop-types</code></a>, <a href="/yannickcr/eslint-plugin-react/blob/v7.12.0/docs/rules/no-unused-prop-types.md"><code>no-unused-prop-types</code></a>: better handle object spread (<a href="https://urls.greenkeeper.io/yannickcr/eslint-plugin-react/pull/1939" data-hovercard-type="pull_request" data-hovercard-url="/jsx-eslint/eslint-plugin-react/pull/1939/hovercard">#1939</a>, <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=93752" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/alexzherdev">@alexzherdev</a>)</li>
</ul>
<h3>Changed</h3>
<ul>
<li><a href="/yannickcr/eslint-plugin-react/blob/v7.12.0/docs/rules/jsx-fragments.md"><code>jsx-fragments</code></a>: improve message text (<a href="https://urls.greenkeeper.io/yannickcr/eslint-plugin-react/pull/2032" data-hovercard-type="pull_request" data-hovercard-url="/jsx-eslint/eslint-plugin-react/pull/2032/hovercard">#2032</a>, <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=93752" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/alexzherdev">@alexzherdev</a>)</li>
<li><a href="/yannickcr/eslint-plugin-react/blob/v7.12.0/docs/rules/no-unsafe.md"><code>no-unsafe</code></a>: handle all unsafe life-cycle methods (<a href="https://urls.greenkeeper.io/yannickcr/eslint-plugin-react/pull/2075" data-hovercard-type="pull_request" data-hovercard-url="/jsx-eslint/eslint-plugin-react/pull/2075/hovercard">#2075</a>, <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=748074" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/sergei-startsev">@sergei-startsev</a>)</li>
<li><a href="/yannickcr/eslint-plugin-react/blob/v7.12.0/docs/rules/require-default-props.md"><code>require-default-props</code></a>: Change error message naming from singular defaultProp to plural defaultProps (<a href="https://urls.greenkeeper.io/yannickcr/eslint-plugin-react/pull/2064" data-hovercard-type="pull_request" data-hovercard-url="/jsx-eslint/eslint-plugin-react/pull/2064/hovercard">#2064</a>, <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=9586897" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/jseminck">@jseminck</a>)</li>
<li>[Refactor] Extract used <code>propTypes</code> detection (<a href="https://urls.greenkeeper.io/yannickcr/eslint-plugin-react/pull/1946" data-hovercard-type="pull_request" data-hovercard-url="/jsx-eslint/eslint-plugin-react/pull/1946/hovercard">#1946</a>, <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=93752" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/alexzherdev">@alexzherdev</a>)</li>
<li>[Refactor] Extract <code>defaultProps</code> detection (<a href="https://urls.greenkeeper.io/yannickcr/eslint-plugin-react/pull/1942" data-hovercard-type="pull_request" data-hovercard-url="/jsx-eslint/eslint-plugin-react/pull/1942/hovercard">#1942</a>, <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=93752" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/alexzherdev">@alexzherdev</a>)</li>
<li>[Refactor] Extract required <code>propTypes</code> detection (<a href="https://urls.greenkeeper.io/yannickcr/eslint-plugin-react/pull/2001" data-hovercard-type="pull_request" data-hovercard-url="/jsx-eslint/eslint-plugin-react/pull/2001/hovercard">#2001</a>, <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=93752" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/alexzherdev">@alexzherdev</a>)</li>
<li>[Docs] <a href="/yannickcr/eslint-plugin-react/blob/v7.12.0/docs/rules/no-did-mount-set-state.md"><code>no-did-mount-set-state</code></a>, <a href="/yannickcr/eslint-plugin-react/blob/v7.12.0/docs/rules/no-did-update-set-state.md"><code>no-did-update-set-state</code></a>, <a href="/yannickcr/eslint-plugin-react/blob/v7.12.0/docs/rules/no-will-update-set-state.md"><code>no-will-update-set-state</code></a>: fix docs URLs (<a href="https://urls.greenkeeper.io/yannickcr/eslint-plugin-react/pull/2090" data-hovercard-type="pull_request" data-hovercard-url="/jsx-eslint/eslint-plugin-react/pull/2090/hovercard">#2090</a>, <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=8250797" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/JBallin">@JBallin</a>)</li>
<li>[Docs] Remove statement on GC in jsx-no-bind (<a href="https://urls.greenkeeper.io/yannickcr/eslint-plugin-react/pull/2067" data-hovercard-type="pull_request" data-hovercard-url="/jsx-eslint/eslint-plugin-react/pull/2067/hovercard">#2067</a>, <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=2440089" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/rickhanlonii">@rickhanlonii</a>)</li>
<li>[Docs] <a href="/yannickcr/eslint-plugin-react/blob/v7.12.0/docs/rules/jsx-sort-props.md"><code>jsx-sort-props</code></a>: Fix small mistake (<a href="https://urls.greenkeeper.io/yannickcr/eslint-plugin-react/pull/2044" data-hovercard-type="pull_request" data-hovercard-url="/jsx-eslint/eslint-plugin-react/pull/2044/hovercard">#2044</a>, <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=8790386" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/dimitarnestorov">@dimitarnestorov</a>)</li>
<li>[Docs] <a href="/yannickcr/eslint-plugin-react/blob/v7.12.0/docs/rules/no-unescaped-entities.md"><code>no-unescaped-entities</code></a>: add more escape examples (<a href="https://urls.greenkeeper.io/yannickcr/eslint-plugin-react/pull/2015" data-hovercard-type="pull_request" data-hovercard-url="/jsx-eslint/eslint-plugin-react/pull/2015/hovercard">#2015</a>, <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=6316590" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/stevemao">@stevemao</a>)</li>
<li>[Docs] <a href="/yannickcr/eslint-plugin-react/blob/v7.12.0/docs/rules/display-name.md"><code>display-name</code></a>: mention default <code>ignoreTranspilerName</code> value (<a href="https://urls.greenkeeper.io/yannickcr/eslint-plugin-react/pull/2002" data-hovercard-type="pull_request" data-hovercard-url="/jsx-eslint/eslint-plugin-react/pull/2002/hovercard">#2002</a>, <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=921609" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/OliverJAsh">@OliverJAsh</a>)</li>
<li>[Docs] <a href="/yannickcr/eslint-plugin-react/blob/v7.12.0/docs/rules/jsx-no-target-blank.md"><code>jsx-no-target-blank</code></a>: Add full example (<a href="https://urls.greenkeeper.io/yannickcr/eslint-plugin-react/pull/1988" data-hovercard-type="pull_request" data-hovercard-url="/jsx-eslint/eslint-plugin-react/pull/1988/hovercard">#1988</a>, <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=3504434" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/atomcorp">@atomcorp</a>)</li>
<li>[Docs] Update <a href="/yannickcr/eslint-plugin-react/blob/v7.12.0/docs/rules/jsx-no-target-blank.md"><code>jsx-no-target-blank</code></a>.md (<a href="https://urls.greenkeeper.io/yannickcr/eslint-plugin-react/pull/1953" data-hovercard-type="pull_request" data-hovercard-url="/jsx-eslint/eslint-plugin-react/pull/1953/hovercard">#1953</a>, <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=827445" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/brunocoelho">@brunocoelho</a>)</li>
<li>[Changelog] fix "Ignore class properties" contributor (<a href="https://urls.greenkeeper.io/yannickcr/eslint-plugin-react/pull/1941" data-hovercard-type="pull_request" data-hovercard-url="/jsx-eslint/eslint-plugin-react/pull/1941/hovercard">#1941</a>, <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=93752" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/alexzherdev">@alexzherdev</a>)</li>
<li>[Tests] Remove redundant <code>require('babel-eslint')</code> from tests (<a href="https://urls.greenkeeper.io/yannickcr/eslint-plugin-react/pull/2004" data-hovercard-type="pull_request" data-hovercard-url="/jsx-eslint/eslint-plugin-react/pull/2004/hovercard">#2004</a>, <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=748074" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/sergei-startsev">@sergei-startsev</a>)</li>
<li>[Tests] <a href="/yannickcr/eslint-plugin-react/blob/v7.12.0/docs/rules/prop-types.md"><code>prop-types</code></a>: Add tests for prop-types destructuring (<a href="https://urls.greenkeeper.io/yannickcr/eslint-plugin-react/pull/2029" data-hovercard-type="pull_request" data-hovercard-url="/jsx-eslint/eslint-plugin-react/pull/2029/hovercard">#2029</a>, <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=10355544" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/sstern6">@sstern6</a>)</li>
<li>[Tests] <a href="/yannickcr/eslint-plugin-react/blob/v7.12.0/docs/rules/display-name.md"><code>display-name</code></a>: add false positive component detection for destructured createElement (<a href="https://urls.greenkeeper.io/yannickcr/eslint-plugin-react/pull/1098" data-hovercard-type="pull_request" data-hovercard-url="/jsx-eslint/eslint-plugin-react/pull/1098/hovercard">#1098</a>, <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=109243" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/arian">@arian</a>)</li>
</ul>
</details>

<details>
<summary>Commits</summary>
<p>The new version differs by 138 commits.</p>
<ul>
<li><a href="https://urls.greenkeeper.io/yannickcr/eslint-plugin-react/commit/a83d65caffb8c62ee5b85446df3ef3f09f1a472c"><code>a83d65c</code></a> <code>Update CHANGELOG and bump version</code></li>
<li><a href="https://urls.greenkeeper.io/yannickcr/eslint-plugin-react/commit/0c6160e72e1ebbe838b5d0f081b7e5ef4d56efc8"><code>0c6160e</code></a> <code>[Dev Deps] update <code>coveralls</code>, <code>babel-eslint</code>, <code>typescript</code></code></li>
<li><a href="https://urls.greenkeeper.io/yannickcr/eslint-plugin-react/commit/cd6c8e6e8675dee345c5d66c2c55e14cf4eea74f"><code>cd6c8e6</code></a> <code>[Deps] update <code>resolve</code></code></li>
<li><a href="https://urls.greenkeeper.io/yannickcr/eslint-plugin-react/commit/d2b5b732adc8fa2c7ad6b3d26eb2d29f7a322d0f"><code>d2b5b73</code></a> <code>Merge pull request #1828 from alexzherdev/1721-no-typos-create-class</code></li>
<li><a href="https://urls.greenkeeper.io/yannickcr/eslint-plugin-react/commit/e7474592f01ce4b100eab24748bc6fd28da3dfd4"><code>e747459</code></a> <code>[Tests] remove node 5/7/9, add node 11</code></li>
<li><a href="https://urls.greenkeeper.io/yannickcr/eslint-plugin-react/commit/b33ae84aba3d2aee1b135c73f5baa7e87f2b5baa"><code>b33ae84</code></a> <code>Merge pull request #1098 from arian/createElement-display-test</code></li>
<li><a href="https://urls.greenkeeper.io/yannickcr/eslint-plugin-react/commit/84be80a6f50aebbdc7945624833cf90291975e6c"><code>84be80a</code></a> <code>Merge pull request #1824 from alexzherdev/1762-jsx-max-depth-false-positive</code></li>
<li><a href="https://urls.greenkeeper.io/yannickcr/eslint-plugin-react/commit/a4420677bd7756a2ede142665c52743f503f29d2"><code>a442067</code></a> <code>Merge pull request #2029 from sstern6/issue1422</code></li>
<li><a href="https://urls.greenkeeper.io/yannickcr/eslint-plugin-react/commit/7d07c3730aebeceddba4559ffd4ec015cf278ca9"><code>7d07c37</code></a> <code>Merge pull request #2032 from alexzherdev/jsx-fragments-message</code></li>
<li><a href="https://urls.greenkeeper.io/yannickcr/eslint-plugin-react/commit/8c6a8e292230a48909331b12dd0f52cef052b62c"><code>8c6a8e2</code></a> <code>Merge pull request #2089 from jomasti/feature/support-react-forwardref-memo</code></li>
<li><a href="https://urls.greenkeeper.io/yannickcr/eslint-plugin-react/commit/14451d4f3da1bac4cbdeaa0d0aca516aa6c2d844"><code>14451d4</code></a> <code>Merge pull request #2085 from himynameisdave/issues/2083</code></li>
<li><a href="https://urls.greenkeeper.io/yannickcr/eslint-plugin-react/commit/8be52c754f0bc5060dc9ef572509a99119069961"><code>8be52c7</code></a> <code>📝 Addresses CR comments</code></li>
<li><a href="https://urls.greenkeeper.io/yannickcr/eslint-plugin-react/commit/f7e312112069eada25086fb5f02ee8ec2ae3d24d"><code>f7e3121</code></a> <code>Merge branch 'master' of <a href="https://urls.greenkeeper.io/yannickcr/eslint-plugin-react">https://github.com/yannickcr/eslint-plugin-react</a> into issues/2083</code></li>
<li><a href="https://urls.greenkeeper.io/yannickcr/eslint-plugin-react/commit/77e3fd027f3c7083e508a79e0a1bcf46c88f4c21"><code>77e3fd0</code></a> <code>Merge pull request #2090 from JBallin/no-method-set-state-docs-url</code></li>
<li><a href="https://urls.greenkeeper.io/yannickcr/eslint-plugin-react/commit/7da9e0da38b1f6a61ac8de786809f2a84ddbad1c"><code>7da9e0d</code></a> <code>Fix noMethodSetState docsUrl's</code></li>
</ul>
<p>There are 138 commits in total.</p>
<p>See the <a href="https://urls.greenkeeper.io/yannickcr/eslint-plugin-react/compare/599c02891f8f2933034fdf2d5359cae6a88f3e9d...a83d65caffb8c62ee5b85446df3ef3f09f1a472c">full diff</a></p>
</details>

<details>
  <summary>FAQ and help</summary>

  There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>

---


Your [Greenkeeper](https://greenkeeper.io) bot 🌴
This was referenced Dec 28, 2018
Closed
Merged
Merged
Closed
Closed
Open
Open
Merged
Open
Open
Open
Open
Closed
Open
Closed
Merged
This was referenced Jan 4, 2019
Merged
Closed
Open
Merged
Closed
Merged
Closed
Merged
Merged
Closed
Closed
Merged
Closed
Merged
Closed
Merged
Merged
Merged
@ghost ghost mentioned this pull request Jan 12, 2019
Merged
1 task
This was referenced Jan 13, 2019
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Aug 17, 2019
Open
Open
This was referenced Sep 22, 2019
Open
Open
@snyk-bot snyk-bot mentioned this pull request Sep 30, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

@yannickcr yannickcr Awaiting requested review from yannickcr

@lencioni lencioni Awaiting requested review from lencioni

@EvHaus EvHaus Awaiting requested review from EvHaus

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexzherdev @ljharb @EvHaus