Fix: no-array-index-key not working in React.Children methods #2085
+95
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the case where you are iterating over a children prop via the React.Children API.
ljharb
requested changes
Dec 15, 2018
- Uses pragma context instead of 'React' - Adds back spaces I removed which increase readability
|
@ljharb I've addressed your CR comments, please read through again and let me know if there is anything else you need me to change! 💪👌🤙 |
ljharb
approved these changes
Dec 21, 2018
1 task
1 task
This was referenced Dec 28, 2018
Closed
This was referenced Jan 8, 2019
ghost
mentioned this pull request
This was referenced Jan 13, 2019
Merged
This was referenced Sep 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
no-array-index-keywas not flagging any errors when iterating viaReact.Childrenmethods. This fixes that!Fixes #2083