Merge branch 'master' into release-v15.0.0

yargs · Oct 31, 2019 · bdb62ec · bdb62ec
2 parents 5a5f0c8 + 445bc58
commit bdb62ec
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/package.json b/package.json
@@ -75,6 +75,6 @@
   ],
   "license": "MIT",
   "engine": {
-    "node": ">=6"
+    "node": ">=8"
   }
 }
diff --git a/test/validation.js b/test/validation.js
@@ -848,6 +848,19 @@ describe('validation tests', () => {
       args.foo.should.equal(true)
       args.bar.should.equal(true)
     })
+
+    it('does not fail when unrecognized option is passed after --', () => {
+      const args = yargs('ahoy ben -- --arrr')
+        .strict()
+        .command('ahoy <matey>', 'piratical courtesy')
+        .option('arrr', { boolean: true, describe: false })
+        .fail((msg) => {
+          expect.fail(msg)
+        })
+        .parse()
+      args.matey.should.equal('ben')
+      args._.should.deep.equal(['ahoy', '--arrr'])
+    })
   })
 
   describe('demandOption', () => {