Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the label for "Implications failed:" in English #1317

Merged
merged 6 commits into from May 8, 2019
Merged

Change the label for "Implications failed:" in English #1317

merged 6 commits into from May 8, 2019

Commits on May 7, 2019

  1. Change the label for "Implications failed:" in English 

    The word "implications" is extremely confusing here. It is only people who know the Yargs API that understand that these are the dependencies created by the `implies()` method.
Users of the CLI have no idea what we are talking about.

This changes the label of the concept to "required argument dependencies".

This string is used in the code as the prelude to a list of "implications" that have failed, not a warning. The earlier form was more an expression of a warning. The new form is more an expression of a title of a list.
    @jandockx
    jandockx committed May 7, 2019
    Copy the full SHA
    505e806 View commit details
    Browse the repository at this point in the history

  2. Change the label for "Implications failed:" to "Missing dependent arg… 

    …uments:", as discussed in PR
    @jandockx
    jandockx committed May 7, 2019
    Copy the full SHA
    abde123 View commit details
    Browse the repository at this point in the history

  3. Change the Dutch label for "Implications failed:" to a phrase like "M… 

    …issing dependent arguments:" in English
    @jandockx
    jandockx committed May 7, 2019
    Copy the full SHA
    b6a7174 View commit details
    Browse the repository at this point in the history

  4. Change the French, German and Italian label for "Implications failed:… 

    …" to a phrase like "Missing dependent arguments:" in English
    @jandockx
    jandockx committed May 7, 2019
    Copy the full SHA
    f0240da View commit details
    Browse the repository at this point in the history

  5. fix test for validation / implies 

    automatically use the expected English validation message
    @jandockx
    jandockx committed May 7, 2019
    Copy the full SHA
    ad22e4d View commit details
    Browse the repository at this point in the history

  6. fix test/yargs too 

    automatically use the expected English validation message
    @jandockx
    jandockx committed May 7, 2019
    Copy the full SHA
    a803f06 View commit details
    Browse the repository at this point in the history