fix: preserve failMessage from showHelpOnFail #2087
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I realized this PR might be unnecessary, and I'm nervous of the side effects associated with my solution. I proposed a solution to the issue mentioned here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #2085
Problem
usage.reset()was settingfailMessageto null, and as a result the message wasn't shown on fail.Solution
I removed the line in
usage.reset()that set the failMessage to null.Questions
Was there a reason for setting failMessage to null that I'm not aware of?
Todo
Assuming this is an okay fix, I'll add unit tests