Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(locale): added hebrew translation #2357

Merged
merged 3 commits into from Jan 5, 2024
Merged

feat(locale): added hebrew translation #2357

merged 3 commits into from Jan 5, 2024

Conversation

mendlero
Copy link
Contributor

@mendlero mendlero commented Sep 9, 2023

added hebrew translation.

Copy link
Member

@shadowspawn shadowspawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @mendlero

Copy link
Member

@shadowspawn shadowspawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prompted by #2361, should add Hebrew to supported translations in documentation too.

@mendlero
Copy link
Contributor Author

on it

Copy link
Member

@shadowspawn shadowspawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant just the Hebrew, but hopefully will merge ok with the other PR! 😄

@bcoe bcoe changed the title added hebrew translation feat(locale): added hebrew translation Jan 5, 2024
@bcoe bcoe merged commit 4266485 into yargs:main Jan 5, 2024
7 checks passed
@bcoe
Copy link
Member

bcoe commented Jan 5, 2024

Thank you for the contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants