Skip to content

Commit

Permalink
perf(plugin-pnp): remove redundant node check (#5615)
Browse files Browse the repository at this point in the history
**What's the problem this PR addresses?**
<!-- Describe the rationale of your PR. -->
<!-- Link all issues that it closes. (Closes/Resolves #xxxx.) -->

#824 added a check that throws an
error on Node < 12 if the `.pnp.cjs` path contains spaces, due to an old
bug in Node.

**How did you fix it?**
<!-- A detailed description of your implementation. -->

Removed the check since the bug has been fixed since Node 12.

**Checklist**
<!--- Don't worry if you miss something, chores are automatically
tested. -->
<!--- This checklist exists to help you remember doing the chores when
you submit a PR. -->
<!--- Put an `x` in all the boxes that apply. -->
- [X] I have read the [Contributing
Guide](https://yarnpkg.com/advanced/contributing).

<!-- See
https://yarnpkg.com/advanced/contributing#preparing-your-pr-to-be-released
for more details. -->
<!-- Check with `yarn version check` and fix with `yarn version check
-i` -->
- [X] I have set the packages that need to be released for my changes to
be effective.

<!-- The "Testing chores" workflow validates that your PR follows our
guidelines. -->
<!-- If it doesn't pass, click on it to see details as to what your PR
might be missing. -->
- [X] I will check that all automated PR checks pass before the PR gets
reviewed.
  • Loading branch information
paul-soporan committed Jul 26, 2023
1 parent 41d1799 commit f5f2f6e
Show file tree
Hide file tree
Showing 5 changed files with 23 additions and 48 deletions.

0 comments on commit f5f2f6e

Please sign in to comment.