Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix the create-react-app e2e test #3988

Merged
merged 2 commits into from Jan 24, 2022
Merged

ci: fix the create-react-app e2e test #3988

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff49ddf
ci: fix the `create-react-app` e2e test
merceyz Jan 15, 2022
a6586d8
chore: remove resolution from storybook e2e
merceyz Jan 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 11 additions & 2 deletions .github/workflows/e2e-cra-workflow.yml
View file
Open in desktop
Expand Up @@ -25,14 +25,23 @@ jobs:
run: |
source scripts/e2e-setup-ci.sh
yarn dlx create-react-app my-cra && cd my-cra
yarn add -D eslint-config-react-app

# TODO: Remove when create-react-app fixes their ESLint setup
yarn add -D eslint-config-react-app eslint

yarn build

- name: 'Running the TypeScript integration test'
run: |
source scripts/e2e-setup-ci.sh
yarn dlx create-react-app my-cra-ts --template typescript && cd my-cra-ts
yarn add -D eslint-config-react-app

# TODO: Remove when create-react-app fixes their ESLint setup
yarn add -D eslint-config-react-app eslint

# TODO: Remove when https://github.com/facebook/create-react-app/pull/11751 is released
yarn add -D @types/testing-library__jest-dom

yarn build
if: |
always()
8 changes: 7 additions & 1 deletion .github/workflows/e2e-storybook-workflow.yml
View file
Open in desktop
Expand Up @@ -26,7 +26,13 @@ jobs:
run: |
source scripts/e2e-setup-ci.sh
yarn dlx create-react-app my-cra && cd my-cra
yarn add -D eslint-config-react-app

# TODO: Remove when https://github.com/webpack-contrib/mini-css-extract-plugin/issues/896 is fixed
yarn set resolution mini-css-extract-plugin@npm:^2.4.5 2.4.5
merceyz marked this conversation as resolved.
Show resolved Hide resolved

# TODO: Remove when create-react-app fixes their ESLint setup
yarn add -D eslint-config-react-app eslint

yarn dlx -p @storybook/cli@next sb init --yes
yarn build-storybook