feat!: move getCustomDataKey to Linker #4505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdanil
force-pushed
the
feat/mv-getcustomdatakey-to-linker
branch
from
3b62397
to
28b0131
Compare
jdanil
force-pushed
the
feat/mv-getcustomdatakey-to-linker
branch
from
28b0131
to
98219db
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
merceyz
changed the title
arcanis
reviewed
Jun 1, 2022
Comment on lines
+141
to
143
| restoreLinkersCustomData: [ | ||
| `linkersCustomData`, | ||
| ] as const, |
There was a problem hiding this comment.
We'll have to bump INSTALL_STATE_VERSION
|
Perfect, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Addresses one of the checklist items listed for Yarn 4 in #3591.
How did you fix it?
Moved the function from Installer to Linker in each of the linkers.
Checklist