fix(pnp): resolve virtual paths in process.dlopen
#4630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merceyz
force-pushed
the
merceyz/fix/pnp-virtual-dlopen
branch
2 times, most recently
from
2cfc195
to
83b182f
Compare
merceyz
force-pushed
the
merceyz/fix/pnp-virtual-dlopen
branch
from
83b182f
to
841f6b3
Compare
arcanis
approved these changes
Jul 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Trying to require a
.nodefile from aportal:dependency with peer dependencies throws an ENOENT error.Fixes #4443
How did you fix it?
Resolve the filename passed to
process.dlopenChecklist