Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a note about the exports field in the PnP spec #4763

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

arcanis
Copy link
Member

@arcanis arcanis commented Aug 16, 2022

What's the problem this PR addresses?

The PnP spec defers to the Node.js specification, but it's easy to miss the subtleties caused by the exports field.

Ref: evanw/esbuild#2473

How did you fix it?

I've added a note to make it clearer that some specific treatment will be needed.

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant