Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pnp): report missing files in watch mode #5132

Merged
merged 4 commits into from Dec 12, 2022

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Dec 9, 2022

What's the problem this PR addresses?

Node.js started watching missing files in nodejs/node#45348 / v19.2.0 so we need to do it as well.

How did you fix it?

Report missing files in watch mode.

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

Copy link
Member

@RDIL RDIL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@merceyz merceyz merged commit 9c1bcc8 into master Dec 12, 2022
@merceyz merceyz deleted the merceyz/fix/pnp-watch-unexsiting-dependencies branch December 12, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants