fix(yarnpkg-pnp): make yarn 2 run on node 13

[sverweij]

What's the problem this PR addresses?

yarn v2 did not run on node 13 because of a problem with pnp - see yarnpkg/yarn#7642 and PR yarnpkg/yarn#7650.

How did you fix it?

• made the redefinition of Module._findPath in applyPatch.ts take into account that the paths parameter can be null
• adapted the type definition of that redefinition and of the function signature to take this into account
• added node 13 to the build matrix so we can see the fix works (or doesn't)
• ran a ./scripts/run-yarn.js build:cli+hook to rebuild the cli & pnp hook code
• ran a ./scripts/run-yarn.js so the .pnp.js has the fix as well

Notes

It seems the windows builds get tripped up by the set -e in workflows/integration-workflow. In windows shell set -e has a different meaning, apparently, and it might be that in the latest images of windows the check on the missing parameter got a bit more strict:

Set-Variable : Missing an argument for parameter 'Exclude'. Specify a parameter of type
'System.String[]' and try again.

PR #549 (typo fix) doesn't green because of this either...

[arcanis]

I remember reading that the default shell for GitHub Actions running on Windows would change - it's probably because of this. I think replacing run with bash should work 🤔

[arcanis]

There's a problem here - you scheduled a major (instead of just prerelease) 🙂

Suggested change

	"semver": "2.0.0",
	"semver": "2.0.0-rc.7",

[sverweij]

dang - ran yarn version patch on each of them instead of that nice version check -i Sorry! 😊 . Fix coming up ...

[sverweij]

fixed

[arcanis]

Suggested change

	"semver": "2.0.0",
	"semver": "2.0.0-rc.8",

[sverweij]

fixed

[sverweij]

I remember reading that the default shell for GitHub Actions running on Windows would change - it's probably because of this. I think replacing run with bash should work 🤔

I've tried it (over here in a demo repo) - but it makes the gh-actions config invalid, so the ci script doesn't get executed (error message: every step must define a uses or run key).

So there's two possible courses of action (there might be more, but this is what I currently see):

• remove the set -e for now
  I've tested it in that same demo repo and with or without set -e, the behaviour is the same - immediate bailout on a failing command. This is because the gh-action is executed with shell: /bin/bash -e {0} on linux anyway - and presumably it's the default behaviour of powershell anyway.
• set up a separate workflow for windows

For now I've taken the liberty to remove the set -e. If you want a separate wf for windows - let me know.

[arcanis]

Perfect, thanks! I've merged #551 to always force the tests to run with Bash - I prefer our runner to be consistent if possible. Good to go 👍