Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disables emoji in our Windows tests until Node is fixed #5763

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

arcanis
Copy link
Member

@arcanis arcanis commented Sep 28, 2023

What's the problem this PR addresses?

Node.js 20.4 broke using emojis in file names: nodejs/node#48673

How did you fix it?

Disabling the code that relies on it (it's just a sanity check anyway).

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@arcanis arcanis merged commit 7b5b84a into master Sep 28, 2023
16 checks passed
@arcanis arcanis deleted the mael/win32-encoding-bug branch September 28, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants