Runs more tests #5875
Merged
Runs more tests #5875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merceyz
reviewed
Oct 26, 2023
| @@ -4,6 +4,8 @@ import os from 'os'; | |||
| import * as execUtils from './execUtils'; | |||
| import * as miscUtils from './miscUtils'; | |||
|
|
|||
| export const major = Number(process.versions.node.split(`.`)[0]); | |||
There was a problem hiding this comment.
I don't think adding this here is necessary when it's only used in tests.
There was a problem hiding this comment.
I still prefer it to duplicating the code, and nodeUtils is as good a place as any. I'd prefer to avoid adding test-specific "general utils", as they are harder to discover.
4 tasks
|
Merged; hopefully with that nodejs/citgm#1022 will pass 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
We don't run the unit tests on Node 20/21 on other OSes than Linux, so we didn't notice that one of them was failing.
How did you fix it?
This diff increases the coverage so we test both the oldest and newest supported releases across all platforms. It also adds Node.js 21, to track regressions before they land into an even release.
Checklist