Update Yarn SDK instructions for Emacs #6120
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domq
force-pushed
the
doc/emacs-instructions
branch
from
efef995
to
c0b422e
Compare
|
Hello, I have had no feedback with this pull request for two weeks? |
arcanis
reviewed
Feb 22, 2024
Comment on lines
+87
to
+99
| If, rather than LSP, you are using `eglot` (either bundled with Emacs 29.1 and later versions, or installed separately), your `.dir-locals.el` should instead read | ||
|
|
||
| ```lisp | ||
| ((typescript-ts-mode | ||
| . ((eglot-server-programs | ||
| . (((tsx-ts-mode typescript-ts-mode typescript-mode) | ||
| . (lambda (&rest ignored) | ||
| (let* ((project-directory (car (dir-locals-find-file default-directory))) | ||
| (tsserver-path (concat project-directory ".yarn/sdks/typescript/bin/tsserver"))) | ||
| `("typescript-language-server" "--stdio" | ||
| :initializationOptions | ||
| (:tserver (:path ,tsserver-path))))))))))) | ||
| ``` |
There was a problem hiding this comment.
If that's the configuration for the most up-to-date version of Emacs, perhaps it should be the first thing in the section?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Emacs-related instructions in the official documentation are lagging behind a bit:
eval-after-loadeven though the recommended.dir-locals.elsettings don't make use of that anymoreeglotpackage which has been merged into Emacs version 29.1How did you fix it?
I provided no code, just a doc touchup.
Checklist
I have read the Contributing Guide.
I have set the packages that need to be released for my changes to be effective.
I will check that all automated PR checks pass before the PR gets reviewed.