Adds a createFolderMount util
#6163
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcanis
commented
Mar 10, 2024
Comment on lines
+141
to
+149
| export function applyFsLayer(origFs: typeof fs, factory: (baseFs: FakeFS<PortablePath>) => FakeFS<PortablePath>) { | ||
| // We must copy the fs into a local, because otherwise | ||
| // 1. we would make the NodeFS instance use the function that we patched (infinite loop) | ||
| // 2. Object.create(fs) isn't enough, since it won't prevent the proto from being modified | ||
| const localFs = {...origFs}; | ||
| const nodeFs = new NodeFS(localFs); | ||
|
|
||
| patchFs(fs, new PosixFS(factory(nodeFs))); | ||
| } |
There was a problem hiding this comment.
I wonder if we could find a way to avoid repeating those indirections when applying multiple mount layers ... perhaps by allowing MountFS to handle an array of mount configuration instead of a single one?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This PR is stacked on top of #6161
What's the problem this PR addresses?
Creating a folder mount requires a bit of non-trivial boilerplate. Not that much code, but a little tricky to remember.
How did you fix it?
Added two functions:
applyFsLayerapplies aFakeFS<PortablePath>on top of thefsmodule.MountFS.createFolderMountreturns aMountFSthat replaces all access to folderXby accesses to folderY.Checklist