Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fslib): add rmPromise/rmSync methods #6226

Merged
merged 4 commits into from May 6, 2024
Merged

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Apr 13, 2024

What's the problem this PR addresses?

The recursive option of rmdir is deprecated in Node.js. Unfortunately, because this lib doesn't expose the rm method, there's no alternative atm. This PR adds that alternative.

https://nodejs.org/api/deprecations.html#DEP0147

...

How did you fix it?

I copied the rmdir implementations into a rm equivalent methods that calls in the fs.rm instead of fs.rmdir.
...

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

RDIL
RDIL previously approved these changes May 3, 2024
Copy link
Member

@RDIL RDIL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arcanis arcanis merged commit 7627325 into yarnpkg:master May 6, 2024
22 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants