feat: better error message for network error #6239
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
This is very minor change to some edge cases of reporting network errors. I added little bit of basic information like response code, method and full url.
Background
Recently plugin yarn oudated took down URL that was used internally, which caused yarn to throw very cryptic error message
The remote server failed to provide the requested resource
. Due to some caching probably it was very hard to reproduce this locally and even on some of our CIs this worked and on some this failed.After many hours of debugging we finally tracked down issue, upgraded plugin and it was solved, but I believe error reporting for failed network request should include at least some basic information that will help users debug in future.
Before
After
Reproduction
Add following plugin to
.yarnrc.yml
...
How did you fix it?
I added little bit of basic information like response code, method and full url.
...
Checklist