Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: normalize INIT_CWD #674

Merged
merged 1 commit into from Jan 9, 2020
Merged

fix: normalize INIT_CWD #674

merged 1 commit into from Jan 9, 2020

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Jan 9, 2020

What's the problem this PR addresses?

The install step of husky >= 4.0.0-beta.4 fails on windows because INIT_CWD starts with /.

Since husky doesn't use an exit code, the install step passes, ref typicode/husky#633

How did you fix it?

Normalize INIT_CWD using npath.fromPortablePath.

@arcanis arcanis merged commit afa784a into yarnpkg:master Jan 9, 2020
@arcanis
Copy link
Member

arcanis commented Jan 9, 2020

Sounds good, thanks!

@merceyz merceyz deleted the normalize_init_cwd branch January 9, 2020 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants