Skip to content

Commit

Permalink
Adds a message when people use PnP (#7556)
Browse files Browse the repository at this point in the history
* Adds a message when people use PnP

* Update en.js
  • Loading branch information
arcanis committed Sep 18, 2019
1 parent 1bdb15a commit 7496345
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 0 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Expand Up @@ -4,6 +4,10 @@ Please add one entry in this file for each change in Yarn's behavior. Use the sa

## Master

- Suggests using the Yarn 2 development trunk on PnP-enabled projects

[#7512](https://github.com/yarnpkg/yarn/pull/7512) - [**Maël Nison**](https://twitter.com/arcanis)

This comment has been minimized.

Copy link
@asfernandes

asfernandes Oct 8, 2019

This link is wrong, pointing to "Fixes link:. #7512" PR.

This comment has been minimized.

Copy link
@Axure

Axure Nov 6, 2019

I didn't write this. It's a change committed in the yarn main repo.


- Preserves linked packages when calling `yarn create`

[#7543](https://github.com/yarnpkg/yarn/pull/7543) - [**Nick McCurdy**](https://github.com/nickmccurdy)
Expand Down
5 changes: 5 additions & 0 deletions src/cli/commands/install.js
Expand Up @@ -560,6 +560,11 @@ export class Install {
this.reporter.warn(this.reporter.lang('npmLockfileWarning'));
}

if (this.config.plugnplayEnabled) {
this.reporter.info(this.reporter.lang('plugnplaySuggestV2L1'));
this.reporter.info(this.reporter.lang('plugnplaySuggestV2L2'));
}

let flattenedTopLevelPatterns: Array<string> = [];
const steps: Array<(curr: number, total: number) => Promise<{bailout: boolean} | void>> = [];
const {
Expand Down
3 changes: 3 additions & 0 deletions src/reporters/lang/en.js
Expand Up @@ -361,6 +361,9 @@ const messages = {

unplugDisabled: "Packages can only be unplugged when Plug'n'Play is enabled.",

plugnplaySuggestV2L1: "Plug'n'Play support has been greatly improved on the Yarn v2 development branch.",
plugnplaySuggestV2L2:
'Please give it a try and tell us what you think! - https://next.yarnpkg.com/getting-started/install',
plugnplayWindowsSupport: "Plug'n'Play on Windows doesn't support the cache and project to be kept on separate drives",

packageInstalledWithBinaries: 'Installed $0 with binaries:',
Expand Down

0 comments on commit 7496345

Please sign in to comment.